getredash / redash

Make Your Company Data Driven. Connect to any data source, easily visualize, dashboard and share your data.
http://redash.io/
BSD 2-Clause "Simplified" License
26.45k stars 4.38k forks source link

wait for the db init & upgrade #7167

Open zachliu opened 2 months ago

zachliu commented 2 months ago

What type of PR is this?

Description

The sleep is for https://github.com/getredash/redash/pull/7166. Otherwise the docker compose run cypress yarn cypress db-seed finds the database not ready.

How is this tested?

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 64.20%. Comparing base (a2611b8) to head (004cb6d). Report is 22 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #7167 +/- ## ========================================== + Coverage 64.15% 64.20% +0.05% ========================================== Files 162 162 Lines 13295 13309 +14 Branches 1883 1886 +3 ========================================== + Hits 8529 8545 +16 + Misses 4432 4431 -1 + Partials 334 333 -1 ``` [see 2 files with indirect coverage changes](https://app.codecov.io/gh/getredash/redash/pull/7167/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getredash)
justinclift commented 2 months ago

k, I guess we can try this and see how it goes with #7166. I'm not personally a fan of using sleep statements, but we can figure out something better later on if it turns out to be needed.