Only evaluate the next state if there's a valid value

getredash / redash

Make Your Company Data Driven. Connect to any data source, easily visualize, dashboard and share your data.

http://redash.io/

BSD 2-Clause "Simplified" License

26.45k stars 4.38k forks source link

Open thiagogds opened 4 days ago

thiagogds commented 4 days ago

I've experience this on my Redash in production. I'm not sure what can cause the value to exist, but be None. I guess it depends on the SQL query.

I followed the same idea of returning a self.UNKNOWN_STATE for cases that we can't know what's happening.

Fixes #5618

eradman commented 20 hours ago

Thanks @thiagogds, try re-basing this change to pick up a fix to the restyled workflow