search

getreuer / qmk-keymap

My keymap & reusable QMK gems
Apache License 2.0
301 stars 45 forks source link

Eager mods do not work with one-shot-modifiers #17

Closed jasonkena closed 1 year ago

jasonkena commented 2 years ago

Less of a bug report, more of a need for better documentation I think. The code in the "One-shot mod-tap key" section breaks by default since MOD_LSFT is eager by default.

getreuer commented 1 year ago

Hi, thank you for very much for this report! You are right, there is a bug that the mod gets stuck when it is both eager and used with that one-shot mod-tap trick. I'll submit a fix for this soon.

getreuer commented 1 year ago

Commit https://github.com/getreuer/qmk-keymap/commit/393fa0b45d21e72803bd6877f83fe195233429bd should fix this so that eager mods work together with the one-shot mod-tap trick. Thanks again for reporting!