Closed TristanCacqueray closed 8 months ago
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
View this failed invocation of the CLA check for more information.
For the most up to date status, view the checks section at the bottom of the pull request.
It seems like this can be useful, please let me know if that makes sense for Achordion. This is similar to the require-prior-idle-ms
property of ZMK, so maybe that should be renamed to ACHORDION_REQUIRE_PRIOR_IDLE_MS
.
@TristanCacqueray thank you for the contribution! A typing streak timeout is a great addition.
In order to merge this, I need you to sign a Contributor License Agreement (CLA) at https://cla.developers.google.com/. You (or your employer) retain the copyright to your contribution. This simply gives permission to use and redistribute your contributions as part of the project. See https://cla.developers.google.com/ for your current agreements on file or to sign a new one. Thanks!
@getreuer sure, that should be good now.
Well I can't tell this really works as expected, it seems like it, but it would be great if you can check that is correctly implemented.
Thanks in advance.
@getreuer thank you for the feedback, I'm glad this is helpful. I have updated the PR with your suggestions, though I haven't tested the change on my keyboard yet.
You're welcome, thanks again for sharing your keymap and its features!
This change adds a new feature to disable mods when in typing streak.