getreuer / qmk-keymap

My keymap & reusable QMK gems
Apache License 2.0
301 stars 45 forks source link

Add support for retro tapping #54

Closed akaralar closed 7 months ago

akaralar commented 7 months ago

I tried to add retro tapping support to fix https://github.com/getreuer/qmk-keymap/issues/51

When a retro key is released during the state is UNSETTLED, Achordion doesn't do any plumbing back and as a result the retro key is not sent.

If the key is determined to be a retro key, we do the same plumbing as when the state is settled to be HOLDING and the retro key is sent correctly.

google-cla[bot] commented 7 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.