Closed akaralar closed 7 months ago
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
View this failed invocation of the CLA check for more information.
For the most up to date status, view the checks section at the bottom of the pull request.
I tried to add retro tapping support to fix https://github.com/getreuer/qmk-keymap/issues/51
When a retro key is released during the state is
UNSETTLED
, Achordion doesn't do any plumbing back and as a result the retro key is not sent.IS_RETRO()
macro defined inprocess_auto_shift.h
but I didn't want to include that file just to be able to access this easy check. If necessary, I can include that file and use theIS_RETRO()
macro instead of the manual layer tap / mod tap check.keymap.c
to check if retro tapping is enabled for the key. If the function not defined the weak overload (tried to mimic other functions above) returns false by default.If the key is determined to be a retro key, we do the same plumbing as when the state is settled to be
HOLDING
and the retro key is sent correctly.