Achordion seems to break combos when mod-tap key held

[jdart]

I used Achordion today and it worked great for the most part but I wasn't able to use mod-tap modifiers with key codes I trigger with a combo. I try to avoid lateral movement with my index fingers, so I use combos for the inner columns of my colemak layout.

For example I press f+p to produce a b, but when I have LSFT_T(KC_S) held, the combo doesn't work and f+p are output.

Here's a link to my keymap where you can see how I set things up.

[getreuer]

Thanks for the clear report and for sharing your keymap. Much appreciated! I'll look into it.

[getreuer]

Sorry, I don't see a way to get Achordion to work properly together with Combos. Combos are handled before the point where userspace code can intercept them, and Combos don't expose APIs that help with this. You could still use Combos and Achordion in the same keymap if combos are pressed only while tap-hold keys aren't held, though that would be hard to do with your keymap, unfortunately. Thanks again for your report.

[getreuer]

On second thought, it is possible to detect when an event comes from a Combo and avoid having Achordion act on it. I just pushed a commit that does that. I don't expect this fully solves interoperation with Combos, but in my testing it does seem to help. I hope this works for you too.

[jdart]

Thanks for the update, it's working for all the cases I've tried so far 🔥

[getreuer]

Fantastic! Glad to hear it =)