feat: Manually inject NG_VALUE_ACCESSOR instead of mocking all component providers - Githubissues

getsaf / shallow-render

Angular testing made easy with shallow rendering and easy mocking. https://getsaf.github.io/shallow-render

MIT License

273 stars 25 forks source link

feat: Manually inject NG_VALUE_ACCESSOR instead of mocking all component providers #189

Closed getsaf closed 4 years ago

getsaf commented 4 years ago

Taking a simpler approach to compatibility with Angular Forms components to solve for: #188

Instead of mocking all component providers in hopes of successfully finding/mocking the NG_VALUE_ACCESSOR, we will now inject NG_VALUE_ACCESSOR into every mock component (whether or not it asks for it).

Pros:

This should handle every scenario for testing mocked components that are used with NgValue

Cons:

Tests for components that use mocks of components that do not actually provide NG_VALUE_ACCESSOR will pass when they should actually fail.