search

getsaf / shallow-render

Angular testing made easy with shallow rendering and easy mocking. https://getsaf.github.io/shallow-render
MIT License
273 stars 25 forks source link

Angular 12 support #200

Closed Timebutt closed 3 years ago

Timebutt commented 3 years ago

Angular 12 was recently released, and when upgrading my repo to Angular 12 using NPM 7 I'm getting error messages about peer dependencies not being correct:

npm WARN Could not resolve dependency:
npm WARN peer @angular/common@"11.x" from shallow-render@11.0.0
npm WARN node_modules/shallow-render
npm WARN   dev shallow-render@"11.0.0" from the root project
npm WARN ERESOLVE overriding peer dependency
npm WARN Found: @angular/compiler@12.0.0
npm WARN node_modules/@angular/compiler
npm WARN   @angular/compiler@"12.0.0" from the root project
npm WARN   4 more (@angular/compiler-cli, ...)

I'm guessing updating this repository to support Angular 12 isn't a lot of work? I'm definitely willing to help out and submit a PR!

getsaf commented 3 years ago

Dang, didn't even notice that Angular 12 upgrade.. I'll see if I can verify and release NG12 support today.

getsaf commented 3 years ago

Done! Sorry, had to test it against an actual NG12 project. Looks good, here's the release: https://github.com/getsaf/shallow-render/releases/tag/v12.0.0

Timebutt commented 3 years ago

Awesome work, thanks! 🙌