search

getsaf / shallow-render

Angular testing made easy with shallow rendering and easy mocking. https://getsaf.github.io/shallow-render
MIT License
273 stars 25 forks source link

Angular 17 support #251

Closed meierw closed 9 months ago

meierw commented 10 months ago

Since Angular 17 is out now, perhaps this library should get updated to support that? Thanks 🙂

daancallaert commented 9 months ago

@getsaf Having an Angular 17 build would be lovely

johnwest80 commented 9 months ago

@getsaf brandon, hi there. can you possibly create an angular 17 build? thx! and i haven't forgotten about getting you more info about the test run speeds around caching. just haven't had time to dig back into it.

getsaf commented 9 months ago

It's on my to-do list. I just need to get the deps changed and make sure the tests still pass.

On Mon, Dec 11, 2023, 12:19 PM john west @.***> wrote:

@getsaf https://github.com/getsaf brandon, hi there. can you possibly create an angular 17 build? thx! and i haven't forgotten about getting you more info about the test run speeds around caching. just haven't had time to dig back into it.

— Reply to this email directly, view it on GitHub https://github.com/getsaf/shallow-render/issues/251#issuecomment-1850520844, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACQM7HAA57EIRYA5ITZOVOTYI46D3AVCNFSM6AAAAAA7UOPC6WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNJQGUZDAOBUGQ . You are receiving this because you were mentioned.Message ID: @.***>

johnwest80 commented 9 months ago

awesome... we are seeing tests slow down with 17 and ultimately browser disconnects, so i'm hoping the update fixes it. appreciated as always!

getsaf commented 9 months ago

I got v17 out. There were no code changes , I just updated the deps and everything else was compatible.

@johnwest80 out of curiosity, are there lots of alwaysImport or alwaysProvidebeing used in your setup? Do tests run quickly if you run a small batch or just a single file?