getsandbox / worker-cli

Sandbox Worker is the core processing component of the Sandbox product
https://getsandbox.com
230 stars 62 forks source link

Correct treatment for soap requests #5

Closed diegobmd closed 9 years ago

nhoughto commented 9 years ago

Hey

Can't accept the PR as the outbound HTTP and sleep()s would negatively effect the Sandbox cloud platform, but interested in your use cases.

What are the scenarios where you want to sleep and make outbound HTTP calls? Is it an OAuth style flow?

Thanks for the interest

nhoughto commented 9 years ago

Should have mentioned, def potential to build some of this into the on-premise version and standalone runtime, would need to design how it fits in though. Scenarios would be great to figure that out.

diegobmd commented 9 years ago

Hi nhoughto

Sorry, but this pull request was sent to you at this moment by mistake. We are still making some changes in the code, and this pull request should be sent to this repository first: https://github.com/luisrpp/sandbox

But basically, these changes were made to support this extention: https://github.com/luisrpp/sandbox-configuration

We wanted to add for each service route the following configuration:

The code still needs some refactoring, and we were holding this pull request for a later momment :)

But we appreciate your comments and we will try to list some features that we think would be helpful not just for us.

Best regards,