getsenic / gatt-python

Bluetooth GATT SDK for Python
MIT License
318 stars 86 forks source link

descriptor_read_value_failed Callback #51

Open jasonspage opened 4 years ago

jasonspage commented 4 years ago

If a descriptor value fails to be read, the Descriptor method read_value will call: self.service.device.descriptor_read_value_failed(self, error=error).

This causes an error because the Descriptor class has no 'service' property. The line should be corrected to: self.characteristic.service.device.descriptor_read_value_failed(self, error=error).

This Class exists in gatt_linux.py. The offending code is on line 541 of this file.

larsblumberg commented 4 years ago

Would you mind creating a PR which we can merge?

On 14. Oct 2019, at 20:35, jasonspage notifications@github.com wrote:

 If a descriptor value fails to be read, the Descriptor method read_value will call: self.service.device.descriptor_read_value_failed(self, error=error).

This causes an error because the Descriptor class has no 'service' property. The line should be corrected to: self.characteristic.service.device.descriptor_read_value_failed(self, error=error).

This Class exists in gatt_linux.py. The offending code is on line 541 of this file.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.