search

getsenic / nuimo-linux-python

Nuimo Python SDK for Linux to connect and communicate with Nuimo controllers made by Senic
https://senic.com
MIT License
52 stars 20 forks source link

setup.py for pip integration #3

Closed gross1989 closed 8 years ago

gross1989 commented 8 years ago

so that homeassist can install the sdk an gattlib

larsblumberg commented 8 years ago

Thanks Tobias, will review now

larsblumberg commented 8 years ago

@shaftoe: Thanks for your your intervention! @gross1989: Can you please explain? – Thanks!

larsblumberg commented 8 years ago

@shaftoe: The author of this PR is Tobias, he's an intern at Senic right now he wants to integrate home-assistant with Nuimo. @gross1989: Do you want me to introduce you to each other via mail?

shaftoe commented 8 years ago

@larsblumberg I think we already exchanged one email, but just to be sure, I'll be happy to help out/give you all I have/know about the topic. Unfortunately I'm busy on a different OS project so I can't find much time for HomeAssistant + Nuimo

gross1989 commented 8 years ago

@larsblumberg feel free to do that @shaftoe I see no problem, the name of pygattlib in pip is gattlib

larsblumberg commented 8 years ago

@gross1989: I guess you have already tried installing nuimo via pip using your changes, right?

gross1989 commented 8 years ago

@larsblumberg yes, with python setup.py install

shaftoe commented 8 years ago

Well, fact is, almost everything worked but not everything. Just check my pull request, there's something commented out (with mention to pygattlib), if I'm not wrong it was fly action

larsblumberg commented 8 years ago

@gross1989: After merging your PR, we should also update the README to reflect this change, right?

gross1989 commented 8 years ago

@larsblumberg in README: you can either set PYTHONPATH or install

larsblumberg commented 8 years ago

@gross1989: Please show me the next time we meet, I'm not yet familiar with installing python modules. Will merge PR now. Thanks again!

gross1989 commented 8 years ago

@larsblumberg ok