search

getsenic / nuimo-windows

Library for Windows 10 platforms to connect and communicate with Nuimo controllers made by Senic
MIT License
23 stars 8 forks source link

Fix for Windows 10 IoT Core #4

Closed hansmbakker closed 8 years ago

hansmbakker commented 8 years ago

Patch intended to fix #2

Remove DispatchOnMainThread (since IoT apps are headless and Dispatcher for the UI thread should be used in the client apps) Increase CancellationToken for SubscribeForCharacteristicNotifications() (otherwise it would think that connection failed)

larsblumberg commented 8 years ago

Dispatching is currently being discussed in https://github.com/getsenic/nuimo-windows/issues/2

larsblumberg commented 8 years ago

@wind-rider Did you have issues with the duration of SubscribeForCharacteristicNotifications's cancellation token?

hansmbakker commented 8 years ago

Yes I initially couldn't connect well, until I increased that value.

Inrego commented 8 years ago

Can confirm issues with cancellation token of 1s

hansmbakker commented 8 years ago

@larsblumberg done.

It would help if there would be a style guideline for the windows repos that could be integrated in IDEs.

StyleCop is one way how to enforce coding style guidelines.

larsblumberg commented 8 years ago

Unfortunately we don't have resources right now to formalize a coding style guide. Please use the existing source code style as a reference for how to format code in pull requests. Thanks!

hansmbakker commented 8 years ago

@larsblumberg great, thanks for merging :) when will a new NuGet version be released?

larsblumberg commented 8 years ago

Would be great to have #8, #9 and #12 merged, too :)