search

getsentry / action-github-commit

GitHub Action to commit to GitHub using the API
MIT License
2 stars 6 forks source link

Replace this action with someone else's #14

Open chadwhitacre opened 1 year ago

chadwhitacre commented 1 year ago

There are actions in the marketplace that solve the same problem, we should use one of those rather than maintaining our own.

https://www.google.com/search?q=action+github+commit

https://github.com/marketplace/actions/add-commit https://github.com/marketplace/actions/git-auto-commit https://github.com/marketplace/actions/github-commit-push https://github.com/marketplace/actions/github-action-for-committing-changes-to-a-repository https://github.com/marketplace/actions/verified-commit

@asottile further suggests that we could reimplement with pre-commit ci or pre-commit ci lite which handles this in a safe manner without exposing creds to GHA.

chadwhitacre commented 1 year ago

We're using https://github.com/EndBug/add-and-commit e.g. here:

https://github.com/getsentry/security-as-code/blob/4b583d16020a90a30be26ab21f15f7087f2b51ed/.github/workflows/codeowners.yaml#L17-L20

leiicamundi commented 1 day ago

Only https://github.com/swinton/commit have the same features as this action. Other GHA in the list use git as the backend, not the GH API which is a hard requirement for having the commits made by a bot marked as "verified"