search

getsentry / action-release

GitHub Action for creating a release on Sentry
Apache License 2.0
446 stars 53 forks source link

Glob support for `sourcemaps` #116

Open austince opened 1 year ago

austince commented 1 year ago

It would be nice not to have to expand this ourselves, eg. just:

with:
  sourcemaps: ui/build/static/js/*.map

This could probably be done with just running the array through minimatch or such.

Originally posted by @amcdnl in https://github.com/getsentry/action-release/issues/43#issuecomment-766800395

armenzg commented 1 year ago

Thanks @austince for filing! At the moment, we're not currently investing in the action but we will look at this when we do.

austince commented 1 year ago

Nice, thanks @armenzg!

we're not currently investing in the action

Does this apply to any changes, or just writing the feature? We may be able to contribute a PR if you'd have the bandwidth to review, but understand if not.

armenzg commented 1 year ago

Nice, thanks @armenzg!

we're not currently investing in the action

Does this apply to any changes, or just writing the feature? We may be able to contribute a PR if you'd have the bandwidth to review, but understand if not.

We welcome PRs! Tag me and I will be able to help.

ricardo-dematos commented 1 year ago

We are using

with:
  sourcemaps: ui/build/static/js/

and it uploads all the sourcemaps.