search

getsentry / action-visual-snapshot

Save and compare your visual snapshots
MIT License
38 stars 7 forks source link

Don't do anything if there are no images to activate #100

Closed mattgauntseo-sentry closed 1 year ago

mattgauntseo-sentry commented 1 year ago

I was trying to debug the visual snapshot showing different results in the action summary vs the generated index.html and noticed this error in the logs where no changes (i.e. all = []) will throw an error on cleanSelector(all[active])} because all[0] results in a call cleanSelector(undefined).

The logging I've added to try and make it easier to debug issues in the future.

mattgauntseo-sentry commented 1 year ago

I can't find the logs, but I had tested this on a PR when I was trying to separate the frontend tests from the acceptance tests.