search

getsentry / action-visual-snapshot

Save and compare your visual snapshots
MIT License
38 stars 7 forks source link

feat: Set the status of transactions #71

Closed armenzg closed 2 years ago

armenzg commented 2 years ago

Currently all transactions are marked as Unknown status, thus, making it hard to determine the failure rate.

This is an initial attempt to distinguish what are successful transactions.

This is a very naive attempt.

armenzg commented 2 years ago

Early feedback welcome as I have not done Node development for a long time.

armenzg commented 2 years ago

This creates both an error and a transaction (now that we have development environment!):

image

The transaction now has an status of "ok" which is wrong 😆 https://sentry.io/organizations/sentry/discover/visual-snapshot-action:dc6030c4b4d14524a74b1c9770518f51/?environment=development&field=title&field=event.type&field=timestamp&name=All+Events&project=5324467&query=&sort=-timestamp&statsPeriod=24h&yAxis=count%28%29

image
armenzg commented 2 years ago

Super-seeded by #75