search

getsentry / action-visual-snapshot

Save and compare your visual snapshots
MIT License
38 stars 7 forks source link

feat(odiff): replace pixelmatch #73

Closed JonasBa closed 2 years ago

JonasBa commented 2 years ago

First PR that replace pixelmatch with odiff. Note that this should not be merged because it will fail to compile (vercel/ncc does not handle binary paths that are copied over correctly).

I will open a followup stacked PR with only changes to the build step so that they can be atomically reviewed.

JonasBa commented 2 years ago

This now contains all of the stacked PR's that were merged here (I wish gh was better with stacked PR's), but I'll make sure to remove dist folder entirely so we can give this another look before merging without looking at the compiled files along with it.

JonasBa commented 2 years ago

@billyvg this should be good to go now. The PR contains all the changes from the stacked PR's, we've been running it on getsentry/sentry for a week now and it's had some pretty good results. I'll probably write a message to eng team, but I think we are much closer to the actual test flake percentage