getsentry / action-visual-snapshot

Save and compare your visual snapshots
MIT License
38 stars 7 forks source link

fix(odiff): change build step to support binaries #74

Closed JonasBa closed 2 years ago

JonasBa commented 2 years ago

Fixes the odiff release process so that binaries are correctly invoked. Sadly, I did not manage to make this work nicely as vercel/ncc fails to analyze the dynamically linked binaries (I have tested converting this to a composite action, using working_directory and using process.chdir but it was still unable to properly resolve it)...

To fix this, I introduced copy-odiff-binaries.js which finds all compiled odiff binaries after yarn finishes installation and copies them to the root of the project. A working run can be seen at https://github.com/getsentry/sentry/pull/35787/checks?check_run_id=6987874434.