ref: Rename backpressure metric

getsentry / arroyo

A library to build streaming applications that consume from and produce to Kafka.

https://getsentry.github.io/arroyo/

Apache License 2.0

39 stars 6 forks source link

ref: Rename backpressure metric #303

Closed lynnagara closed 7 months ago

lynnagara commented 7 months ago

Rename arroyo.consumer.paused.time to arroyo.consumer.backpressure.time

Two main motivations for this:

The new metric matches the name emitted by the Rust consumer, we should align these exactly to make the transition smoother
The consumer is no longer actually paused immediately when backpressure happens (we now wait until we are in the backpressure state for at least a second as pausing is expensive). So the old metric name is kind of misleading now.

lynnagara commented 7 months ago

i feel that the renaming breaks too many dashboards, and that we shouldn't do it too often with metrics in general. but for this one it's probably fine.

I'll make sure to update (afaik there's one for sentry and one for snuba). I don't think there's any other metrics that need to be changed.