search

getsentry / arroyo

A library to build streaming applications that consume from and produce to Kafka.
https://getsentry.github.io/arroyo/
Apache License 2.0
41 stars 7 forks source link

perf: replace `HashMap` with `FxHashMap` #337

Closed anonrig closed 4 days ago

anonrig commented 8 months ago

This is a breaking change since we need to update Snuba to use FxHashMap instead of HashMap. I believe the performance benefits makes this justifiable, but I'm not sure what the policy is for breaking changes.

I didn't run any benchmark but depending on the response I'll open a PR to update Snuba as well and share the benchmark results.

untitaker commented 4 days ago

since this PR is significantly out of date now I'll just close it, I don't think there is a strong need to get rid of HashMap