search

getsentry / babel-gettext-extractor

A fork of babel-gettext-plugin that works with older versions of node and supports comment and location extraction
MIT License
43 stars 22 forks source link

Babel6 conversion #2

Closed ian-ross closed 7 years ago

ian-ross commented 8 years ago

Don't know if you're interested in this, but we're using Babel 6, and the plugin setup has changed quite a bit from Babel 5. This is a first attempt at updating your gettext extractor for those changes.

This change is Reviewable

muffinresearch commented 8 years ago

We're starting to use these patches over here on another temporary fork [1] and they look to be working fine. I'm curious to know if there's any plans to update this project to babel 6 in the near future?

[1] https://github.com/muffinresearch/babel-gettext-extractor

mitsuhiko commented 8 years ago

I will take a look at it.

benvinegar commented 8 years ago

@mitsuhiko – can you take another look? I've started upgrading getsentry/sentry to Babel 6, and this is the current blocker (support was added in the original babel-gettext-plugin).

benvinegar commented 7 years ago

Closed in favor of #3 – publishing the Babel API changes in version 2.0.0