getsentry / craft

The universal Sentry release CLI 🚀
MIT License
133 stars 15 forks source link

Do not rely on hacky solution for checksum validation #418

Open kamilogorek opened 2 years ago

kamilogorek commented 2 years ago

The solution here is not great, and it would be nice to have something more reliable, as this was already a fix for previously happening incident: https://github.com/getsentry/craft/blob/477308a7bd2154a156600cb8a4a07f555a629cd4/src/targets/github.ts#L398-L404

Original issues: https://github.com/getsentry/craft/pull/308 https://github.com/getsentry/craft/pull/328 Jira ref: FUNT-22