search

getsentry / craft

The universal Sentry release CLI 🚀
MIT License
133 stars 15 forks source link

feat: powershell target #515

Closed vaind closed 8 months ago

vaind commented 9 months ago

This adds powershell publishing support

vaind commented 9 months ago

can you write some tests for your new feature

The PR is still a draft (a.k.a not ready for review) and the unrelated stuff will be split out + I hope to add tests if I can figure it out. Currently I'm testing it manually and trying to fix unrelated issues with zip file download

bruno-garcia commented 8 months ago

Thanks @vaind for raising this!

bruno-garcia commented 8 months ago

@asottile-sentry please let me know if we need any other change to get this through

vaind commented 8 months ago

Thx. Can you please merge as well? I don't have permissions

On Mon, 11 Mar 2024, 16:48 anthony sottile, @.***> wrote:

@.**** approved this pull request.

apologies I was out sick the last week and change (still am) but going to approve to unblock

https://camo.githubusercontent.com/85f8965a2c34def7000687646fdb65c472209133f6a378e918530f73be868109/68747470733a2f2f692e666c756666792e63632f71487a66634236425a395a44374b3377466b6e714c737248717371353662504d2e676966

— Reply to this email directly, view it on GitHub https://github.com/getsentry/craft/pull/515#pullrequestreview-1928216941, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABQOG4QBUNQUHKIS4WJDW2DYXXN5ZAVCNFSM6AAAAABD2NCFBGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSMRYGIYTMOJUGE . You are receiving this because you were mentioned.Message ID: @.***>

bruno-garcia commented 8 months ago

Thanks @vaind and @asottile-sentry !

bruno-garcia commented 8 months ago

@asottile-sentry hope u get well soon 🙏