getsentry / craft

The universal Sentry release CLI 🚀
MIT License
131 stars 16 forks source link

craft needs to be more flexible with github artifact names #552

Open joshuarli opened 1 month ago

joshuarli commented 1 month ago

github upload-artifact v3 is deprecated and v4 currently doesn't allow uploading different filepaths to the same artifact name

upstream issue: https://github.com/actions/upload-artifact/issues/478

currently craft expects the artifact name to be github.sha

this blocks:

i propose a quick fix to check for this as a prefix if {sha} isn't found (so that we don't break things): craft-{sha}-

also, this is annoying but there are going to be multiple artifact ziparchives now with craft-{sha}- for example symbolicator will need the following, and current code assumes just one artifact per revision

  - /^symbolicator-Darwin-universal$/
  - /^symbolicator-Linux-x86_64$/
  - /^symbolicator-Linux-x86_64-debug.zip$/
  - /^symbolicator-aarch64-apple-darwin-debug.zip$/
  - /^symbolicator-x86_64-apple-darwin-debug.zip$/
  - /^symbolicli-Darwin-universal$/
  - /^symbolicli-Linux-x86_64$/
  - /^symbolicli-Windows-x86_64\.exe$/
  - /^symsorter-Darwin-universal$/
  - /^symsorter-Linux-x86_64$/
  - /^symsorter-Windows-x86_64\.exe$/
  - /^wasm-split-Darwin-universal$/
  - /^wasm-split-Linux-x86_64$/
  - /^wasm-split-Windows-x86_64\.exe$/
BYK commented 1 month ago

Although less than ideal, artifacts/merge action might be a temporary solution.