Craft version 2.0.0 appears to have broken `sentry-cli` PyPI releases

szokeasaurusrex commented 3 weeks ago

Environment

getsentry/publish

Steps to Reproduce

Release a new version of Sentry CLI

Expected Result

The release succeeds, including the PyPI release, as it did with [version 2.36.2 of Sentry CLI](publish: getsentry/sentry-cli@2.36.2)publish: getsentry/sentry-cli@2.36.2, which was the last version of Sentry CLI released with Craft <2.0.0.

Actual Result

Ever since Craft version 2.0.0 was released, the PyPI release fails:

[info] [[target/pypi]] Uploading file "sentry_cli-2.36.4.tar.gz" via twine
Error:  Process "twine" errored with code 1

STDOUT: twine: Uploading distributions to https://upload.pypi.org/legacy/
twine: Uploading sentry_cli-2.36.4-py3-none-linux_x86_64.whl
twine: 25l
  0% ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 0.0/5.8 MB • --:-- • ?
  8% ━━━╺━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 0.5/5.8 MB • 00:01 • 14.6 MB/s
100% ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 5.8/5.8 MB • 00:00 • 61.2 MB/s
100% ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 5.8/5.8 MB • 00:00 • 61.2 MB/s
100% ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 5.8/5.8 MB • 00:00 • 61.2 MB/s
100% ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 5.8/5.8 MB • 00:00 • 61.2 MB/s
100% ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 5.8/5.8 MB • 00:00 • 61.2 MB/s
twine: 25hWARNING  Error during upload. Retry with the --verbose option for more details. 
twine: ERROR    HTTPError: 400 Bad Request from https://upload.pypi.org/legacy/        
twine:          Binary wheel 'sentry_cli-2.36.4-py3-none-linux_x86_64.whl' has an      
twine:          unsupported platform tag 'linux_x86_64'.                               
twine: 

STDERR:twine: 

  STDOUT: twine: Uploading distributions to https://upload.pypi.org/legacy/
  twine: Uploading sentry_cli-2.36.4-py3-none-linux_x86_64.whl
  twine: 25l
  0% ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 0.0/5.8 MB • --:-- • ?
  8% ━━━╺━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 0.5/5.8 MB • 00:01 • 14.6 MB/s
100% ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 5.8/5.8 MB • 00:00 • 61.2 MB/s
100% ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 5.8/5.8 MB • 00:00 • 61.2 MB/s
100% ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 5.8/5.8 MB • 00:00 • 61.2 MB/s
100% ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 5.8/5.8 MB • 00:00 • 61.2 MB/s
100% ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 5.8/5.8 MB • 00:00 • 61.2 MB/s
  twine: 25hWARNING  Error during upload. Retry with the --verbose option for more details.
  twine: ERROR    HTTPError: 400 Bad Request from https://upload.pypi.org/legacy/
  twine:          Binary wheel 'sentry_cli-2.36.4-py3-none-linux_x86_64.whl' has an
  twine:          unsupported platform tag 'linux_x86_64'.

Full logs are available for Sentry CLI releases [2.36.3](publish: getsentry/sentry-cli@2.36.3)publish: getsentry/sentry-cli@2.36.3 and 2.36.4, both of which were released with Craft 2.0.0.

If I am reading the logs for the Sentry CLI 2.36.2 release correctly, it looks like Craft only started attempting to upload the linux_x86_64 binary with Craft 2.0.0.

asottile-sentry commented 3 weeks ago

I don't think this was a craft change -- the linux_x86_64 wheel was never included in the artifact until https://github.com/getsentry/sentry-cli/pull/2158 which erroneously included it

szokeasaurusrex commented 3 weeks ago

@asottile-sentry you might be right, I think I misread the changelog and thought there was a successful release since https://github.com/getsentry/sentry-cli/pull/2158

getsentry / craft