search

getsentry / docker-sentry

Docker Official Image packaging for Sentry
https://sentry.io
Other
349 stars 150 forks source link

"chown -R sentry /var/lib/sentry/files" takes a long time on some setups #200

Closed stumbaumr closed 5 years ago

stumbaumr commented 5 years ago

As discussed in https://github.com/getsentry/onpremise/issues/239 with some setups this chown takes over 20 minutes.

Thanks for pulling and I hope this is the correct file...

mattrobenolt commented 5 years ago

We'd likely want this applied back to the 9.1 folder too, I assume.

BYK commented 5 years ago

@mattrobenolt isn't 9.1 on code-freeze ATM? Otherwise, I'd argue we'd need a 9.1.3 release?

BYK commented 5 years ago

@stumbaumr thanks a lot for the PR btw, this looks good to me! Once we resolve the question @mattrobenolt raised, I'll accept and merge.

mattrobenolt commented 5 years ago

We don’t version anything based on the packaging here. I’d just merge and update the 9.1.2 tag. Ideally, we’d have an independent packaging version, and we’d have like, 9.1.2-1 or something. But I don’t think it matters enough.

BYK commented 5 years ago

@mattrobenolt fair enough. @stumbaumr - would you mind applying the same change to the 9.1 folder so we can ship it to more people? :)