search

getsentry / eng-pipes

Automations for the Engineering organization ([get]sentry CI/CD tooling, metrics, issues/label management, ...)
Apache License 2.0
5 stars 1 forks source link

fix(gocd-job-runner): Fixing approved by to check if valid sentry email #841

Closed IanWoodard closed 1 week ago

IanWoodard commented 1 week ago

Added a check for the gocd-job-runner's deployFeed to ensure we only try to cc a user if the approvedBy is a valid Sentry email.

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.09%. Comparing base (7200e7c) to head (9c84614). Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #841 +/- ## ========================================== + Coverage 89.07% 89.09% +0.01% ========================================== Files 127 128 +1 Lines 3726 3732 +6 Branches 768 753 -15 ========================================== + Hits 3319 3325 +6 - Misses 375 395 +20 + Partials 32 12 -20 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.