search

getsentry / raven-csharp

Superseded by: https://github.com/getsentry/sentry-dotnet
BSD 3-Clause "New" or "Revised" License
231 stars 121 forks source link

Background worker client #242

Closed bruno-garcia closed 6 years ago

bruno-garcia commented 6 years ago

Breaking changes: RavenClient BeforeSend hook exposes now: IRequester which doesn’t have some members.

Requester was renamed to HttpRequester Lost two public members: IRavenClient JsonPacket Continues to expose the actual RequestData though

HttpRequester no longer calls RavenSharp’s public method PrepareData followed by constructing RequestData in its constructor.

The caller (which in the library is only RavenClient anyway) should invoke this method (in itself) then create the RequestData to provide the HttpRequester.

QueueRequester which upon request invoked queues up for background worker.

bruno-garcia commented 6 years ago

This is an idea to fulfill @chris-smith-zocdoc requirement described at: #239 WIP as I didn't really test it much. Let's discuss the design first. Let me know your thoughts.

/cc @mitsuhiko @asbjornu

bruno-garcia commented 6 years ago

Could you guys let me know what you think? I'd like to finalize this.

// @asbjornu @chris-smith-zocdoc @mitsuhiko

bruno-garcia commented 6 years ago

@asbjornu
That's a good idea. It'd include the Contexts stuff. I guess I can look into that tomorrow, unless you want to take it over

asbjornu commented 6 years ago

@bruno-garcia: I’m on vacation now and you’re doing great on your own here so do as you please! :smile:

bruno-garcia commented 6 years ago

2.4 was released, so now with this code merged into develop, we'll have 2.4.1-preview released. @chris-smith-zocdoc would you be able to run the preview?