search

getsentry / raven-csharp

Superseded by: https://github.com/getsentry/sentry-dotnet
BSD 3-Clause "New" or "Revised" License
231 stars 121 forks source link

Wrong device architecture in SharpRaven.Data.Context.Device #256

Closed mogikanin closed 6 years ago

mogikanin commented 6 years ago

We use raven-csharp in windows desktop app. packages.cofig:

  <package id="SharpRaven" version="2.4.0" targetFramework="net461" />
  <package id="System.Runtime.InteropServices.RuntimeInformation" version="4.3.0" targetFramework="net461" />

We are running x86 process on x64 Windows, and raven-csharp reports x86 architecture in Device section. I guess there is a typo on this line: https://github.com/getsentry/raven-csharp/blob/develop/src/app/SharpRaven/Data/Context/Device.cs#L215 There should be RuntimeInformation.OSArchitecture.ToString();

bruno-garcia commented 6 years ago

You're right! RuntimeInformation.ProcessArchitecture should go into App. This difference is actually documented here: https://github.com/getsentry/dotnet-sentry-platform-abstractions/issues/7 We're hoping to extract this logic into a new component.