search

getsentry / raven-go

Sentry client in Go
https://sentry.io
BSD 3-Clause "New" or "Revised" License
561 stars 147 forks source link

Fix bug: panic not being sent #202

Closed andreiolariu closed 5 years ago

nvartolomei commented 6 years ago

You can use CapturePanicAndWait if you want to wait for panic to be sent. If you're using Capture directly, then you can wait on the err channel to be closed.

Or, you're relying on PanicHandler which is broken see #194.

andreiolariu commented 6 years ago

Yes, I am using PanicHandler, but no panics are being sent to the sentry server. I debugged around and found the script ending before it got the chance to make the request. I added that line to wait for it. I guess I should have tried using CapturePanicAndWait instead.

mattes commented 6 years ago

I believe this PR can be closed.

cc @mattrobenolt