CaptureErrorAndWait swallows error

getsentry / raven-go

Sentry client in Go

https://sentry.io

BSD 3-Clause "New" or "Revised" License

561 stars 147 forks source link

CaptureErrorAndWait swallows error #216

Open femaref opened 5 years ago

femaref commented 5 years ago

I've had a problem with events not reaching an on premise server. Reason was that the go process did not have the relevant CA installed. This error was completely dropped and without changing the library you can't get it. I don't see a reason why it's not possible to show the error, especially with AndWait.

I'll make changes to the code and submit a PR soon.

OGKevin commented 5 years ago

@femaref any updates on this? I think my implementation is also not working as expected.

femaref commented 5 years ago

I'm working on it, in the mean time you can print the result of the chan receive here: https://github.com/getsentry/raven-go/blob/3033899c76deb3fb6570d9c4074d00443aeab88f/client.go#L740