search

getsentry / raven-go

Sentry client in Go
https://sentry.io
BSD 3-Clause "New" or "Revised" License
561 stars 147 forks source link

Set default timeout for transport http client #250

Closed r-cohen closed 5 years ago

r-cohen commented 5 years ago

By default, the http.Client has a Timeout of 0, which means no timeout (infinite long lived connection). this is source of hang in high latency environment but also can be source of memory leaks. I suggest adding a default timeout to avoid this.

kamilogorek commented 5 years ago

Sounds reasonable. Thanks!

r-cohen commented 5 years ago

@kamilogorek thanks! have a pleasant day.