Add custom parameters to HTTPTrasport and setters

getsentry / raven-go

Sentry client in Go

https://sentry.io

BSD 3-Clause "New" or "Revised" License

561 stars 147 forks source link

Open sshaplygin opened 5 years ago

sshaplygin commented 5 years ago

It is modify PR #222 with custom HTTPTransport client parameters.

kamilogorek commented 5 years ago

PR introduces options

// HTTPTransportOptions are options to configure the HTTPTransport yet it contains 5 separate setters for all the timeouts.

Wouldn't it be better to configure it once during transport creation? It will most likely never change once configured anyway.

sshaplygin commented 5 years ago

@kamilogorek Hi! It is good idea. I gonna fix soon time