search

getsentry / raven-go

Sentry client in Go
https://sentry.io
BSD 3-Clause "New" or "Revised" License
561 stars 148 forks source link

Redact header and query fields in NewHttp(). #73

Closed thorduri closed 8 years ago

thorduri commented 8 years ago

N.B: Query fields must now match a component of QuerySecretFields, rather then the component being a substring of the field.

Substring matches has very interesting behaviour (redacts eg. password_required fields etc) and IMO violates POLA, especially since it makes little sense to do this for header fields and having the redaction behaviour the same is I think worth it.

I don't currently have a use case for redactCookies() but it would be trivial to add it.

thorduri commented 8 years ago

Thanks for taking a look @mattrobenolt I've replied to your line comments!

thorduri commented 8 years ago

The branch will stay available here for a while.