kamilogorek
commented
7 years ago Koa itself doesn't provide parsers, you have to attach them yourself, that's why body is always empty.
Use https://github.com/koajs/bodyparser and this.request to report errors.
Also your implementation is using generators, which will be dropped in v3 of Koa and it's written in a way that it'll never reach catch clause (you can verify it using --inspect flag and Chrome Devtools).
Working example:
'use strict';
const PORT = 3000;
const Koa = require('koa');
const Router = require('koa-router');
const bodyParser = require('koa-bodyparser');
const Raven = require('raven');
Raven.config('__DSN__').install();
const app = new Koa();
const router = new Router();
function* errors(next) {
let err;
try {
yield next;
} catch (e) {
err = e;
this.body = { message: err.message };
} finally {
Raven.captureException(err, { req: this.request }, (sendErr, eventId) => {
if (sendErr) console.error('Failed to send captured exception to Sentry', err);
});
}
}
app.use(bodyParser());
app.use(errors)
router.post('/', function (ctx, next) {
throw new Error('oh hi');
});
app
.use(router.routes())
.use(router.allowedMethods());
app.listen(PORT);
console.log(`Server listening on port: ${PORT}`);
chrisjensen
What is the current behavior?
Raven.captureException does not process the request properly in koa app.
Minimum example at this gist.
In the gist, you can see four ways I've tried to capture the request (lines 29 to 32)
The relavent lines are:
Test this server by sending a post request to
http://localhost:3000/errorwith some body includedHere's the information that's recorded about the request in my sentry dashboard from those different configurations
What is the expected behavior?
At least one of these ways of attaching the request should cause the full request to be saved, ie: