Open newhouse opened 6 years ago
actually, i lied:
updating to 2.4.2
didn't fix the infinite loop issue (something else I changed did), and that's probably another issue I should file besides this one. Will need to dig into that one more when I have time.
Nevertheless, the issue in the title still remains.
Hi there, sometime the things I want to capture with Raven/Sentry are not Error instances (but sometimes they are).
I was having an issue with raven
^2.30
going into an infinite loop while doing the following-ish:I guess raven's parser somehow went into an infinite loop trying to stringify
channelInstance
and eventually the max frames were reached. So, I updated to latest raven2.4.2
and now the infinite loop is gone, but if I pass a non-Error
instance tocaptureException
, any additional context I pass is overwritten and not sent to Sentry.Example:
It seems like when a non-Error instance is passed to
captureException
that Raven will not only NOT merge/use the originalsomeContext
that was passed BUT ALSO will overwrite thesomeContext
object. ThesomeContext
does not make it to Sentry in my issues, which means that information is lost.I would expect that it would merge the
someContext
I passed with whatever stuff it wants to (__serialized__
, etc) but it doesn't.Am I doing something wrong, or is this a bug?