getsentry / raven-python

Raven is the legacy Python client for Sentry (getsentry.com) — replaced by sentry-python
https://sentry.io
BSD 3-Clause "New" or "Revised" License
1.68k stars 657 forks source link

Match nodejs client environment variable support #1213

Closed alukach closed 6 years ago

alukach commented 6 years ago

I was surprised to find that the Python client does not support the same environment variables documented in the NodeJS client. This is a quick fix so maybe there's a particular reason that this choice was made that I'm not aware of. However, I'd recommend adding support for these variables.

This PR is mostly about kicking the tires on the idea. If this is something that we're interested in merging, I can throw together some quick tests to verify that these remain effective for time to come.

alukach commented 6 years ago

i'm a little bit lost as to why I'm getting slapped so hard on these tests, any tips?

ashwoods commented 6 years ago

@alukach can you rebase from master?

alukach commented 6 years ago

@ashwoods done, thanks for the pointer.

ashwoods commented 6 years ago

thx!