search

getsentry / raven-python

Raven is the legacy Python client for Sentry (getsentry.com) — replaced by sentry-python
https://sentry.io
BSD 3-Clause "New" or "Revised" License
1.68k stars 657 forks source link

doc: captureException: "requisite clean-up" #1269

Open blueyed opened 6 years ago

blueyed commented 6 years ago

The doc for captureException says:

If exc_info is not provided, or is set to True, then this method will perform the exc_info = sys.exc_info() and the requisite clean-up for you.

From the direct code however there appears to be no cleanup being done here?

https://github.com/getsentry/raven-python/blob/03559bb05fd963e2be96372ae89fb0bce751d26d/raven/base.py#L804-L824

It would be nice to clarify/fix this.

I am running into the issue where captureException does not handle being used outside of an exception handler (https://github.com/getsentry/raven-python/issues/938), and want to use captureMessage therefore instead, but the "requisite clean-up" part confused me, since it sounds like I should do something in this regard then maybe, too.

abdourahimjallow commented 6 years ago

Cool