search

getsentry / raven-python

Raven is the legacy Python client for Sentry (getsentry.com) — replaced by sentry-python
https://sentry.io
BSD 3-Clause "New" or "Revised" License
1.68k stars 657 forks source link

syntax error on python 3.7 #1277

Closed AlecRosenbaum closed 5 years ago

AlecRosenbaum commented 5 years ago

I'm getting this error on python 3.7 inside of docker. Using the python 3.6 image everything seems to be working fine.

    from raven.exceptions import InvalidGitRepository
  File "/usr/local/lib/python3.7/site-packages/raven/__init__.py", line 53, in <module>
    from raven.base import *  # NOQA
  File "/usr/local/lib/python3.7/site-packages/raven/base.py", line 691
    if transport.async:
                     ^
SyntaxError: invalid syntax
mattrobenolt commented 5 years ago

Ah, in 3.7 async is now a reserved word.

01walid commented 5 years ago

Any news on this? the docs claims the support of Python 3.7 though ..

eli-schwartz commented 5 years ago

It was fixed a year and a half ago in commit 67f4e89fbdaad42b7bf61b493a7b9d70d8e464b1, so why are you running a pre-6.x version?

astrojuanlu commented 5 years ago

Perhaps this issue can be closed as such then?

AlecRosenbaum commented 5 years ago

I'm feeling pretty foolish now, @eli-schwartz is correct about it being fixed in 6.x. Looks like we have version 5.x pinned.

Guess it's time to update!