search

getsentry / raven-python

Raven is the legacy Python client for Sentry (getsentry.com) — replaced by sentry-python
https://sentry.io
BSD 3-Clause "New" or "Revised" License
1.68k stars 657 forks source link

Update processors.py #1279

Closed ehfeng closed 5 years ago

ehfeng commented 5 years ago

Current regex does not match against credit card numbers in the stack local values, because they are wrapped in single quotes: '4242424242424242'. It could be that credit card numbers should always be represented as integers, but it seems harmless to catch this case as well.

Fixes #1253

153957 commented 5 years ago

Can you add a test which verifies that this fixes #1253?

untitaker commented 5 years ago

I'm closing this because we need something way more generic that checks on arbitrary word boundaries. Also we don't want to have this kind of logic in SDKs in the future anyways.