SENTRY_IGNORE_EXCEPTIONS setting is not flexible enough

getsentry / raven-python

Raven is the legacy Python client for Sentry (getsentry.com) — replaced by sentry-python

https://sentry.io

BSD 3-Clause "New" or "Revised" License

1.68k stars 657 forks source link

SENTRY_IGNORE_EXCEPTIONS setting is not flexible enough #304

Open Geekfish opened 11 years ago

Geekfish commented 11 years ago

I posted this in a comment a few days ago, but I think it's better to open an issue for it:

I think this is undocumented but I might have missed it, I wanted to ask though why was the decision made to change from skip_sentry toSENTRY_IGNORE_EXCEPTIONS ?

Amongst other things skip_sentry worked with inheritance, and could be conditionally set on each instance, now this is no longer possible as far as I can tell.

dcramer commented 11 years ago

@Geekfish the goal was a focus on common client interfaces. Mostly things that could be configured in similar manners so it was more obvious.

We could probably continue to support a sentry attribute.