search

getsentry / raven-python

Raven is the legacy Python client for Sentry (getsentry.com) — replaced by sentry-python
https://sentry.io
BSD 3-Clause "New" or "Revised" License
1.68k stars 657 forks source link

Make `max_frames` option configurable. #578

Open jaseemabid opened 9 years ago

jaseemabid commented 9 years ago

I usually end up with stack traces way bigger than the current 50, and often important info is lost with a error message Frames 12 until 22 were omitted and not available..

Can we make this option configurable? I would send a PR if its ok.

dcramer commented 9 years ago

We can but our primary concern here is total size of data storage.

Keep in mind the server will also implement restrictions, so even if a client decides not to send something, the server may flat out reject it, or it may just truncate it anyways.

jaseemabid commented 9 years ago

I host the sentry server and data storage size is not the primary concern. Older data is purged to limit storage size rather than limit the size of individual exceptions. When the exceptions arrive, I'll rather see all the available data.

Silent truncation would be a bad idea. In case the server cannot store the data, it should ideally error out, so that the users know what is happening. They could either increase the limit at the server or decrease at the client rather than be completely clueless.

dcramer commented 9 years ago

@jaseemabid while that may seem like its fine, throwing errors from your error logging platform simply because data is too big doesn't sit well with us, or generally any users of Sentry

jaseemabid commented 9 years ago

You dont have to throw an error, you can just log.error