search

getsentry / relay

Sentry event forwarding and ingestion service.
https://docs.sentry.io/product/relay/
Other
321 stars 91 forks source link

Redis sentinel support #2875

Open doc-sheet opened 10 months ago

doc-sheet commented 10 months ago

Hello.

Since 0.23.1 redis-rs supports sentinel. Could you add it to relay please?

olksdr commented 10 months ago

Hey,

thanks for opening the issue!

Could you, please, provide more context for this feature request? Why do you need it? How that will help you with using the Relay? Any specific issue it will solve for you?

It will give us more information to consider before plan it out and putting the work on our roadmap.

doc-sheet commented 10 months ago

Sure. I want to setup failover for redis connection. Sentinel is way simpler than redis cluster and supports select db statement so i can point whole sentry stack to the same redis machines.

Other (python) services can be configured to use sentinel with a bit of code in config but relay is the one where i need to manually update redis server address when db instance crashes.

On the other hand redis-rs now have native support for sentinel so relay could be much more stable in that scenario.

olksdr commented 10 months ago

Thanks for the additional context! I will bring this up to the team for discussion and followup actions.

jernejstrasner commented 10 months ago

Hi @doc-sheet, We can take this with very low priority but you are welcome to contribute and we'll be happy to review.

doc-sheet commented 10 months ago

Sadly I never touched rust. I'll better leave it to someone else. Thank you!