search

getsentry / relay

Sentry event forwarding and ingestion service.
https://docs.sentry.io/product/relay/
Other
312 stars 85 forks source link

feat(web-vitals): add support for mobile browsers #3762

Closed KevinL10 closed 6 days ago

KevinL10 commented 1 week ago

Adds support for mobile browsers to start ingesting web vitals.

Continuation of https://github.com/getsentry/sentry/pull/73298/ which adds the scoring percentile configuration for mobile browsers.

Dav1dde commented 1 week ago

I wonder if we should normalize the mobile browsers instead 🤔 .

KevinL10 commented 1 week ago

We could normalize browser.name but we still need a way to distinguish mobile browsers from desktop browsers since they have different scoring configurations. If we add a new tag it might be confusing for people who use span search and are already filtering by specific browser.name types like Chrome Mobile.

iker-barriocanal commented 1 week ago

I think these browser names are set by relay by checking the user agent?

I'm ok with merging as-is, but a test to validate that would be great.