search

getsentry / responses

A utility for mocking out the Python Requests library.
Apache License 2.0
4.14k stars 354 forks source link

chore: allow urllib3>=1.25.10 #659

Closed JohnVillalovos closed 1 year ago

JohnVillalovos commented 1 year ago

Allow use of urllib3>=1.25.10. By default it will use urllib3>=2 as that is the latest version. But this will allow people to pin urllib3<2 and still use the latest version of requests and responses.

Closes: #657

codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (78854ab) 100.00% compared to head (b5ed6ee) 100.00%.

:exclamation: Current head b5ed6ee differs from pull request most recent head 7ab8732. Consider uploading reports for the commit 7ab8732 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #659 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 9 9 Lines 2875 2875 ========================================= Hits 2875 2875 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

beliaev-maksim commented 1 year ago

please add a matrix of tests in CI. We need to test on both 1.x and 2.x

otherwise we give a promise that we cannot guarantee

JohnVillalovos commented 1 year ago

please add a matrix of tests in CI. We need to test on both 1.x and 2.x

otherwise we give a promise that we cannot guarantee

Thanks.

Done, I think. The CI doesn't run for me yet so I'm not 100% certain.

JohnVillalovos commented 1 year ago

@beliaev-maksim or @markstory Can one of you enable the workflows to run? Thanks.

JohnVillalovos commented 1 year ago

Done, I think. The CI doesn't run for me yet so I'm not 100% certain.

I was able to run the CI over in my fork. And I got the tests to pass. https://github.com/JohnVillalovos/responses/pull/2