search

getsentry / responses

A utility for mocking out the Python Requests library.
Apache License 2.0
4.14k stars 354 forks source link

Calls info in BaseResponse #664

Closed zeezdev closed 11 months ago

zeezdev commented 1 year ago

Sometimes it is more convenient to get information about the calls made directly from the mockend request, instead of calculating the order of your calls in the global list (responses.calls[n]).

What do you think of such a possibility?

codecov[bot] commented 1 year ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Files Coverage Δ
responses/__init__.py 100.00% <100.00%> (ø)
responses/tests/test_responses.py 100.00% <100.00%> (ø)

:loudspeaker: Thoughts on this report? Let us know!.

zeezdev commented 1 year ago

also, CHANGELOG entry is missing

Added the CHANGELOG entry.

markstory commented 11 months ago

This is looking good, a few small formatting issues in the README that need to be fixed up before this can be merged.

zeezdev commented 11 months ago

This is looking good, a few small formatting issues in the README that need to be fixed up before this can be merged.

Fixed.

zeezdev commented 11 months ago

It looks like mypy problems is related to v1.6.1 that released several days ago.

I added several ignore comments related to my changes and old code. Please review again.

beliaev-maksim commented 11 months ago

@markstory can you please do a final pass here

beliaev-maksim commented 11 months ago

@zeezdev great work, thanks!