search

getsentry / responses

A utility for mocking out the Python Requests library.
Apache License 2.0
4.08k stars 347 forks source link

fix coverage on master #677

Closed beliaev-maksim closed 9 months ago

beliaev-maksim commented 9 months ago

change the order of dependencies installation to ensure that urllib3 is not overwritten. Otherwise we have an issue that we do not test urllib3<2

@markstory I do not feel super comfortable with the order of installation of packages. In theory we can end up that we have artificial packages meaning that we override those packages that are specified in setup.py and we test not the real package.

from CI I see the following error

types-requests 2.31.0.7 requires urllib3>=2

for me it feels that we still have to drop urllib3<2 since the upstream is moving towards it.

codecov[bot] commented 9 months ago

Codecov Report

All modified lines are covered by tests :white_check_mark:

Files Coverage Δ
responses/__init__.py 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

:loudspeaker: Thoughts on this report? Let us know!.

beliaev-maksim commented 9 months ago

CI fails on the coverage, it is clear that urllib3 is overwritten by 2.x instead of 1.x

I will have a look