Closed woodyza closed 5 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
89d7f37
) 99.93% compared to head (dd7b873
) 99.93%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thank you 🎉
Thanks @markstory for the merge 🙏 Any idea when 0.25.0
might come out?
@woodyza I started a release build just now.
Awesome, thanks!
Hi!
When #651 was implemented the header matching rule was subtly broken, making it no longer detect when the specified headers were missing entirely (vs present, but with the wrong value) unless you used strict matching.
As far as I understand that is not the intention, and you should be able to use the header matcher to detect missing headers without necessarily caring about all of the other headers in the request. It's a small change to enable that, and it preserves the strict match and regex match logic.
I've added a test case that fails without the current change, and the rest of the cases still pass with it in place.