Open andrew-cybsafe opened 1 month ago
Changing the default values is not something we can easily do at this point in time as it will break existing assumptions in userland code.
I have tried setting responses.mock.assert_all_requests_are_fired = True in conftest.py or just after an import of requests.
Because of fixes we had to make to fix nested scopes, I don't think this is currently working. But it should be possible to have it work.
@markstory I've opened PR https://github.com/getsentry/responses/pull/731 for this.
Describe the bug
When a
RequestsMock()
is used as a context manager,assert_all_requests_are_fired
is defaulted to True and an exception is raised at the end of the context block if a response is unused. However, using the@responses.activate
decorator on a test function defaultsassert_all_requests_are_fired
to False leading to inconsistent behaviour.Additional context
As a workaround, I have tried setting
responses.mock.assert_all_requests_are_fired = True
in conftest.py or just after an import of requests. However, this does not change the behaviour. The issue appears to be that the value in the default mock is never used as it gets defaulted by a default parameter inactivate()
, see: code.Version of
responses
0.25.3
Steps to Reproduce
Expected Result
Both test cases to fail with:
Actual Result
First test case fails. Second test case passes.